[Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

[js361014]

>Please explain to me why there is a need for the large diff in notebook.c since this should just shuffle widgets around.

There is no one global search bar, so it's not just shuffling widgets around.
In a rough approximation:
- 30% relates to a need to pass search bar elements to each other
- 10% relates to performing a searching
- 10% relates to attaching signals to elements
- 30% relates to updating the search bar state
- 20% relates to building the search bar

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#issuecomment-520896016
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190813/1760333d/attachment.html>