[Github-comments] [geany/geany] build.c: ASSIGNIF -> assign_cmd (#2256)

[Thomas Martitz]

Why even post a PR if you're reluctant to even minor suggestions? I guess responding in a comment here takes about the same time as following the suggestion (that you generally support). So if this is your reaction to review comments please just push directly, this has the same result and saves us time (I just wasted my time by reviewing this and writing this comment.), and have the thing reverted if anyone bothers enough (I doubt).

I'm trying to be not rude (really!) but this is my personal impression of this PR:
"Hey, I prepared this change with a poor title and no description and code changes that leave room for improvements. But better not request changes because it's wasting my time and there is higher priority stuff elsewhere".

>  I support using an intermediate variable for common expressions, but this should be done for bigger functions in build.c first.

This doesn't make a lot of sense to me. You edited this code and it could be improved while you're at it. Why avoid improving this code just because there are other, bigger functions that can also be improved?

And why are you even doing this change at all if there are other refactoring of higher priority?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2256#issuecomment-520861292
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190813/bc065599/attachment.html>