[Github-comments] [geany/geany-plugins] lineoperations: add support for locale-aware sorting (#897)

Sylvan Mostert notifications at xxxxx
Mon Aug 12 00:42:53 UTC 2019


This PR is in response to #819.

Changes:
- add preferences option: 'Use collation based string compare'
![image](https://user-images.githubusercontent.com/15589754/62841538-6a2d6200-bc77-11e9-9e64-61ee8e994d23.png)

- `getcmpfns()` returns either `g_utf8_collate` or `strcmp` function pointer to line operations function based on user preference

Minor:

- add help function to redirect to online documentation
- split files into `lo_prefs` and `lo_fns`
- sorry about all the annoying indentation / spacing changes / file renaming.


I'm open to hear any suggestions/improvements.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/897

-- Commit Summary --

  * lineoperations: minor formatting changes
  * lineoperations: add preferences
  * lineoperations: split files into fns and prefs
  * lineoperations: abstract string compare fns
  * lineoperations: add documentation for prefs
  * lineoperations: match indentation

-- File Changes --

    M lineoperations/ChangeLog (9)
    M lineoperations/README (102)
    M lineoperations/src/Makefile.am (6)
    M lineoperations/src/lineoperations.c (82)
    R lineoperations/src/lo_fns.c (137)
    R lineoperations/src/lo_fns.h (15)
    A lineoperations/src/lo_prefs.c (127)
    A lineoperations/src/lo_prefs.h (59)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/897.patch
https://github.com/geany/geany-plugins/pull/897.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/897
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190811/b720c370/attachment.html>


More information about the Github-comments mailing list