[Github-comments] [geany/geany] plugin cleanup: Fix glib warning about unconnected signal handler. (#183)

[LarsGit223]

@elextr, @kugel-:
Yes, it is still valid, see the code below taken from current master today:
``` C
static void remove_callbacks(Plugin *plugin)
{
	GArray *signal_ids = plugin->signal_ids;
	SignalConnection *sc;

	if (signal_ids == NULL)
		return;

	foreach_array(SignalConnection, sc, signal_ids)
	{
		g_signal_handler_disconnect(sc->object, sc->handler_id);
		g_object_weak_unref(sc->object, on_object_weak_notify, plugin);
	}

	g_array_free(signal_ids, TRUE);
}
```
It would be cool if someone could fix the conflicts and merge this - one PR less.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/183#issuecomment-520253682
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190811/36c1e965/attachment.html>