[Github-comments] [geany/geany] Does not preserve file modes (#2251)

[elextr]

> ... write to temporary file by yourself and call fsync+close and fix file modes and ACL's etc before renaming over the original file.

Thats what the GIO setting does (as described in the wiki article).

The Glib and GIO library code is quite complex, since it has to handle various file systems (you can mount windows file systems on Linux and vice versa, so its not just your native file system types) and it takes into account network file systems characteristics.

Since the Geany contributors do not have the range of different systems, nor the other resources, to test such code to the level that something as critical as writing your superb code to disk deserves, it is unlikely that it will be reinvented locally, even if "somebody" made a pull request.

Glib and GIO are heavily used libraries that have a fair chance of most bugs being bashed out of them, a little tested local replica would not be likely to be an improvement.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2251#issuecomment-519851386
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190809/a3fdfadf/attachment.html>