[Github-comments] [geany/geany-plugins] Addons: Open Documents menu opens in wrong location when button in drop-down (#892)

[PatrickGMM]

Using Geany version 1.35 compiled under linux mint 19.1 cinnamon for GTK version 2.24.32. Using version 1.35 of the plugins pack compiled under the same config.

The problem occurs when the button for the Open Documents feature is rolled-up into the drop-down button (when the toolbar isn't wide enough to display the button). The button in this case has no parent window, so you need to get the window of the parent of the button for calculating the position of the Open Documents window in ao_popup_position_menu() in ao_doclist.c.

How I fixed it on my machine (ao_doclist.c):
 	GdkWindow *window = gtk_widget_get_window(widget);
 	gint widget_height;
 
+	if (window == NULL && GTK_IS_TOOL_BUTTON(widget)) {
+		/* The button was rolled-up into a drop-down list (since the main
+		*  window isn't wide enough to contain the button), so get the parent's
+		*  window instead
+		*/
+		window =  gtk_widget_get_window (gtk_widget_get_parent(widget));
+	}
+
 	/* Retrieve size and position of both widget and menu */
 	if (! gtk_widget_get_has_window(widget))
 	{


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/892
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190806/f6fcd136/attachment.html>