[Github-comments] [geany/geany] Plugin-API: extended project API (#2234)

[elextr]

I personally prefer getters/setters since that is more likely to allow Geany to change internals without affecting the API, but that said, its not been the standard approach to date, instead the entrails have been exposed as @codebrainz suggested.  But if the project_prefs structure is already exposed and its just another member being documented, then thats probably ok.

It would probably be possible to add a `document_before_open` signal that provides the filename and returns `true` to continue opening and `false` to not do the open.  Then you can stash the filename and stop the open until you are ready to do it.

Also on the topic of your crash mentioned above, Geany is not reentrant, you need to be very careful that your signal callbacks don't call Geany functions that get back into the code that called the callback.  Thats why some stuff needs to be done on the idle so its not called from any Geany function and can use them all.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2234#issuecomment-517914746
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190803/cf59a94c/attachment-0001.html>