[Github-comments] [geany/geany] Restart the shell if VTE restart is requested (#2116)

Colomban Wendling notifications at xxxxx
Sat Apr 27 17:02:09 UTC 2019


b4n approved this pull request.

Not sure why we need to kill the child, but this works for me for correcting the issue.  I would have though the `child-exited` handler should do all what is needed, but well.

FTR, I can reproduce seeing "weird behavior" of the directory following feature after restarting the terminal.  I say weird because it stops working with some directories, maybe the one in which it was when it got restarted or something?  I didn't investigate far enough but it looks reasonable when looking at the code.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2116#pullrequestreview-231430005
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190427/21805169/attachment-0001.html>


More information about the Github-comments mailing list