[Github-comments] [geany/geany-plugins] Workbench: Remove not needed explicit OK and CANCEL button (#842)

[LarsGit223]

LarsGit223 commented on this pull request.



> @@ -289,8 +289,8 @@ gboolean dialogs_directory_settings(WB_PROJECT_DIR *directory)
 	dialog = gtk_dialog_new_with_buttons(_("Directory settings"),
 										 GTK_WINDOW(wb_globals.geany_plugin->geany_data->main_widgets->window),
 										 flags,
-										 _("_Cancel"), GTK_RESPONSE_CANCEL,
-										 _("_OK"), GTK_RESPONSE_ACCEPT,
+										 GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
+										 GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,

Found this blog which says it was deprecated to save memory, see https://blogs.gnome.org/tko/2005/10/26/gtk-builtin-stock-icons-removed/. On this quick search I did not find anything from the gtk development team. Anyway, we can't change it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/842#discussion_r275166112
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190414/12ebb73a/attachment.html>