[Github-comments] [geany/geany-plugins] Workbench: Remove not needed explicit OK and CANCEL button (#842)

[LarsGit223]

LarsGit223 requested changes on this pull request.



> @@ -289,8 +289,8 @@ gboolean dialogs_directory_settings(WB_PROJECT_DIR *directory)
 	dialog = gtk_dialog_new_with_buttons(_("Directory settings"),
 										 GTK_WINDOW(wb_globals.geany_plugin->geany_data->main_widgets->window),
 										 flags,
-										 _("_Cancel"), GTK_RESPONSE_CANCEL,
-										 _("_OK"), GTK_RESPONSE_ACCEPT,
+										 GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
+										 GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,

As per the documentation under https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-CANCEL:CAPS stock items are deprecated. I think it should better stay as-is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/842#pullrequestreview-226401980
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190414/731c07ea/attachment.html>