[Github-comments] [geany/geany] Update copyright years (#2106)

Colomban Wendling notifications at xxxxx
Fri Apr 5 10:57:22 UTC 2019


b4n approved this pull request.

IANAL, so as this doesn't seem crazy I'll just trust your research here.  I'm used to see copyright ranges or the most recent year, but it might just be people that don't know what they're doing and copy somebody else :)

Nothing else to add to @elextr review.

For PO files I usually just sed-replace the relevant things instead of performing a full re-generation as it's virtually impossible to review.  In this case however I quickly went over one and it looked fine, and I trust you anyway so it's fine :)

> @@ -1,7 +1,7 @@
 /*
  *      main.c - this file is part of Geany, a fast and lightweight IDE
  *
- *      Copyright 2014 Matthew Brush <mbrush at codebrainz.ca>
+ *      Copyright 2005 The Geany contributors

That date change is kinda odd

> @@ -1,6 +1,6 @@
 /*
 *
-*   Copyright (c) 2014, Colomban Wendling
+*   Copyright (c) 2005 The Geany contributors

Here as well, although I'm surprised the content of this file is actually new since 2014, I'd probably have been moved here then instead, so maybe 2005 is fine indeed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2106#pullrequestreview-223208778
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190405/4e6f882e/attachment.html>


More information about the Github-comments mailing list