[Github-comments] [geany/geany] switch between document tab when clicking on arrow button bug (#1890)

[elextr]

@b4n and other gtk spurts

The code to detect being on the tab bar background uses styles "scroll-arrow-hlength" and "scroll-arrow-vlength" as part of the calculation of position.

But those appear to be scrollbar arrows, not notebook tabs arrows [here](https://developer.gnome.org/gtk3/stable/GtkWidget.html) and are not mentioned in [notebook styles](https://developer.gnome.org/gtk3/stable/GtkNotebook.html).  Its theme dependent how big scrollbar arrows and tabbar arrows are, so maybe where scrollbar arrows are small and tabbar arrows are large [this](https://github.com/geany/geany/blob/97547edb52e34b8f78f44a13548a0fb55baf1a44/src/notebook.c#L351) code is finding parts of the tabbar arrow are outside the arrow and ripe for double clicking?

IMHO that code and the widget layout dependent checks [here](ttps://github.com/geany/geany/blob/97547edb52e34b8f78f44a13548a0fb55baf1a44/src/notebook.c#L517) are wrong, they depend on implementation dependent things and now some implementations have changed.

Since the feature is implemented wrongly and is undiscoverable it should indeed be removed (by commenting if you want) until "somebody" PRs a correct implementation that doesn't depend on styles and GTK widget layouts.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1890#issuecomment-431709235
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181021/4f17f5d4/attachment.html>