[Github-comments] [geany/geany-plugins] Scope: fix Automake conditional when building for Windows (#787)

Colomban Wendling notifications at xxxxx
Wed Nov 7 23:21:02 UTC 2018


> LGBI. The build error on Linux and GTK3 seems to only appear on Travis CI environment.

Nah it's my bad, dddd4bcc0ee5c756e08b3cffa13bdf43cad2ba1c removes the check for whether Scope is enabled because I thought it was redundant but didn't realize this conditional was in utilslib…

…which IMO is a very bad thing.  BTW, as is I doubt the vtecompat thing in utilslib makes much sense, because it seems highly specific to Scope's use of it, but well.

Anyway, the test should be in the corresponding module, so as it's in utilslib it should be in the utils checks.
I did that in the latest version of this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/787#issuecomment-436814153
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181107/1d6e10c1/attachment.html>


More information about the Github-comments mailing list