[Github-comments] [geany/geany-plugins] Ported 'Debugger' plugin to GTK+3. (#645)

[mattcaswell]

mattcaswell requested changes on this pull request.



>  	
 	cell->enabled = TRUE;
 	cell->condition = NULL;
 	cell->hitscount = 0;
-	
-	cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE;
+
+	g_value_init(&mode, G_TYPE_ENUM);

This should be:

    g_value_init(&mode, GTK_TYPE_CELL_RENDERER_MODE);

Otherwise you get errors like this:

````
(geany:16953): GLib-GObject-WARNING **: 00:27:20.736: ../../../../gobject/gvalue.c:188: cannot initialize GValue with type 'GEnum', this type is abstract with regards to GValue use, use a more specific (derived) type

(geany:16953): GLib-GObject-CRITICAL **: 00:27:20.736: g_value_set_enum: assertion 'G_VALUE_HOLDS_ENUM (value)' failed

(geany:16953): GLib-GObject-CRITICAL **: 00:27:20.736: g_value_transform: assertion 'G_IS_VALUE (src_value)' failed

(geany:16953): GLib-GObject-WARNING **: 00:27:20.736: unable to set property 'mode' of type 'GtkCellRendererMode' from value of type '(null)'
````

> @@ -53,7 +53,12 @@ static gint cell_renderer_toggle_activate(GtkCellRenderer *cell, GdkEvent *event
 static void cell_renderer_toggle_init (CellRendererToggle *cell)
 {
 	GtkCellRenderer *cell_renderer = (GtkCellRenderer*)cell;
-	cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE;
+	GValue mode = G_VALUE_INIT;
+
+	g_value_init(&mode, G_TYPE_ENUM);

Again this should be:

    g_value_init(&mode, GTK_TYPE_CELL_RENDERER_MODE);

>  	cell->pixbuf_active = cell->pixbuf_highlighted = 0;
+
+	g_value_init(&mode, G_TYPE_ENUM);

Again this should be:

    g_value_init(&mode, GTK_TYPE_CELL_RENDERER_MODE);

I found this through testing this PR. Without doing the above you cannot change the current active frame in the stack.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#pullrequestreview-124629631
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180530/c32bf244/attachment.html>