[Github-comments] [geany/geany-plugins] Markdown: replace Discount and PEG Markdown with CMark (#747)

Matthew Brush notifications at xxxxx
Fri May 25 03:49:51 UTC 2018


codebrainz commented on this pull request.



> @@ -0,0 +1,43 @@
+if MD_BUILTIN_CMARK
+
+noinst_LTLIBRARIES = libcmark.la
+
+libcmark_la_SOURCES = \
+	blocks.c \
+	buffer.c \
+	buffer.h \
+	chunk.h \
+	cmark.c \
+	cmark_ctype.c \
+	cmark_ctype.h \
+	cmark.h \

Good call on the `cmark_version.h` missing. I tried to run `make distcheck` but it failed in what seemed like not my plugin's code (in `util` IIRC), will have to try again.

Will look at generating `cmark_version.h`, I was too lazy to bother as the changes I made are quite trivial to reproduce if/when I update the embedded version, but it is better to generate it. I briefly looked at `cmark_export.h.in` but I couldn't really figure out where it came from, and I can't read the awful `cmake` language.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/747#discussion_r190784748
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180524/7d653e66/attachment.html>


More information about the Github-comments mailing list