[Github-comments] [geany/geany-plugins] Markdown: add support for webkit2gtk (#746)

Matthew Brush notifications at xxxxx
Thu May 24 06:14:17 UTC 2018


codebrainz commented on this pull request.



> @@ -49,13 +49,13 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
     GTK_VERSION=2.16
     WEBKIT_VERSION=1.1.13
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],

I think the versions listed are "supported" in that they're known to build and work for the plugin, but not that they are "supported" upstream, obviously. IMO, if it's a simple matter of a few ugly `#ifdef` it's worthwhile even if just to allow people on slightly older distros to compile the latest plugin release tarball.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/746#discussion_r190475064
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180523/21027bee/attachment.html>


More information about the Github-comments mailing list