[Github-comments] [geany/geany] tagmanager: do not rewind file on '# format=ctags' (#1816)

[elextr]

No, that won't work.  Simply not rewinding will leave the file having read BUFSIZ which is guaranteed to be at least 256, so well past the end of the type spec that is to be skipped.  So have to always rewind, then forward over the `# format=ctags` part (probably keep the length from having found it).

Or I'm not sure why it doesn't use getline() instead of reading BUFSIZ, but anyway.

Also noticed the "skip" code [here](https://github.com/geany/geany/blob/7c6b4794b1c0f9696465fb8920ccffc107f5b4d8/src/tagmanager/tm_source_file.c#L360) would seem to actually be an infinite loop?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1816#issuecomment-375467068
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180322/7238c169/attachment.html>