[Github-comments] [geany/geany-plugins] Overview "breaks" focus cycle (#731)

Colomban Wendling notifications at xxxxx
Thu Mar 22 00:40:34 UTC 2018


@codebrainz It doesn't. This seems not to break anything:
```diff
diff --git a/overview/overview/overviewscintilla.c b/overview/overview/overviewscintilla.c
index 41840638..40e46fc8 100644
--- a/overview/overview/overviewscintilla.c
+++ b/overview/overview/overviewscintilla.c
@@ -691,6 +691,8 @@ overview_scintilla_init (OverviewScintilla *self)
   memcpy (&self->overlay_color, &def_overlay_color, sizeof (OverviewColor));
   memcpy (&self->overlay_outline_color, &def_overlay_outline_color, sizeof (OverviewColor));
 
+  gtk_widget_set_can_focus (GTK_WIDGET (self), FALSE);
+
   gtk_widget_add_events (GTK_WIDGET (self),
                          GDK_EXPOSURE_MASK |
                          GDK_FOCUS_CHANGE_MASK |
```

FWIW, without this, if you focus the overview you can get funny behavior, like <kbd>Ctrl+A</kbd> that will select everything in the overview :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/731#issuecomment-375141246
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180321/edc1d225/attachment-0001.html>


More information about the Github-comments mailing list