[Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)

Matthew Brush notifications at xxxxx
Sun Mar 11 14:46:23 UTC 2018


codebrainz commented on this pull request.



> @@ -138,11 +138,7 @@ PLUGIN_SET_TRANSLATABLE_INFO(
 static GList*
 _gtk_cell_layout_get_cells(GtkTreeViewColumn *column)
 {
-#if GTK_CHECK_VERSION(2, 12, 0)

Why not remove this whole function? It looks like it was only added for backwards compatibility pre-2.12, and has a confusing name.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/723#pullrequestreview-102884524
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180311/4ab51ce8/attachment.html>


More information about the Github-comments mailing list