[Github-comments] [geany/geany] GI compatible msgwin_*_add (#1748)

Colomban Wendling notifications at xxxxx
Sat Mar 10 03:02:20 UTC 2018


b4n requested changes on this pull request.

Sorry…
Otherwise looks good, just need updating the `@since`, squashing and we're good to merge.

> @@ -488,6 +519,32 @@ void msgwin_status_add(const gchar *format, ...)
 	}
 }
 
+/**
+ * Logs a formatted status message *without* setting the status bar.
+ *
+ * Use @ref ui_set_statusbar() to display text on the statusbar.
+ *
+ * @param format @c printf()-style format string.
+ * @param ...    Arguments for the @c format string.
+ *
+ * @see msgwin_status_add_string()
+ *
+ * @since 0.15

Seems to be 0.12 actually :]
Or drop it, because it wasn't in the original and nobody actually cares

>   *
- * @since 0.15
+ * @param msg_color A color to be used for the text. It must be an element of #MsgColors.
+ * @param line      The document's line where the message belongs to. Set to @c -1 to ignore.
+ * @param doc       @nullable The document. Set to @c NULL to ignore.
+ * @param format    @c printf()-style format string.
+ * @param ...       Arguments for the @c format string.
+ *
+ * @see msgwin_msg_add_string()
+ *
+ * @since 0.16

good catch for 0.16 here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1748#pullrequestreview-102837822
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180310/aaa3cc32/attachment.html>


More information about the Github-comments mailing list