[Github-comments] [geany/geany-plugins] geanyctags: Use base path as relative to the project file path (#755)

[Jiří Techet]

techee commented on this pull request.



> @@ -205,6 +205,26 @@ static gchar *generate_find_string(GeanyProject *prj)
 }
 
 
+static const gchar *get_base_path(void)
+{
+	static gchar *ret = NULL;

@codebrainz Thanks. While I wouldn't care much for a standalone application (such code is used in Geany's tag manager for instance), your argument about dangers of `static` in dynamically loaded libraries is something worth considering so I have rewritten the patch to avoid this problem.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/755#discussion_r195908384
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180616/3709d4ff/attachment-0001.html>