[Github-comments] [geany/geany-plugins] geanyctags: Use base path as relative to the project file path (#755)

Colomban Wendling notifications at xxxxx
Thu Jun 14 15:36:45 UTC 2018


b4n approved this pull request.

LGBI

> @@ -205,6 +205,26 @@ static gchar *generate_find_string(GeanyProject *prj)
 }
 
 
+static const gchar *get_base_path(void)
+{
+	static gchar *ret = NULL;

I'm not particularly fond of the non-reentrant semantic, but it indeed has the advantage of making other code changes simple.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/755#pullrequestreview-128847208
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180614/89bebfae/attachment.html>


More information about the Github-comments mailing list