[Github-comments] [geany/geany-plugins] vimode: Fix goto_down with line wrapping (#748)

[Jiří Techet]

Yep, looks good to me. I don't use wrapping much so I haven't noticed this. I can imagine there will be more problems with wrapping with some other commands.

Your patch works correctly because SET_POS_NOX() doesn't update the remembered x position and subsequent SCI_LINEDOWN recovers it. It's real pity there's no getter for the remembered x position in Scintilla and that we have to do stuff like this.

@frlan Can be merged I think.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/748#issuecomment-397270441
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180614/000c3e94/attachment.html>