[Github-comments] [geany/geany] GI compatible msgwin_*_add (#1748)

Colomban Wendling notifications at xxxxx
Fri Jan 26 08:56:37 UTC 2018


b4n requested changes on this pull request.

Otherwise looks good

>   *
- *  @param msg_color A color to be used for the text. It must be an element of #MsgColors.
- *  @param format @c printf()-style format string.
- *  @param ... Arguments for the @c format string.
+ * @see msgwin_compiler_add_string()
+ *
+ * @since 0.15

Is that correct?  Looks to me it's new in 921f010ffc38aaadf7118161b2f85df58e7bfc5c which seems to be [0.16](https://github.com/geany/geany/blob/921f010ffc38aaadf7118161b2f85df58e7bfc5c/configure.in#L5)
It doesn't matter much at all, but wrong info isn't nice.

> @@ -488,6 +519,32 @@ void msgwin_status_add(const gchar *format, ...)
 	}
 }
 
+/**
+ * Logs a formatted status message *without* setting the status bar.
+ *
+ * Use @ref ui_set_statusbar() to display text on the statusbar.
+ *
+ * @param format @c printf()-style format string.
+ * @param ...    Arguments for the @c format string.
+ *
+ * @see msgwin_status_add_string()
+ *
+ * @since 0.15

Same

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1748#pullrequestreview-91774332
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180126/7b85248d/attachment.html>


More information about the Github-comments mailing list