[Github-comments] [geany/geany-plugins] Port both webhelper and markdown to webkit2gtk (#677)

Chow Loong Jin notifications at xxxxx
Wed Jan 17 18:08:01 UTC 2018


This is a port of both webhelper and markdown to webkit2gtk (webkit2gtk-4.0). webkitgtk-1.0 is now deprecated, as is webkitgtk-3.0. Unfortunately, this also means that gtk2 is no longer supported for these plugins. This PR also includes changes from https://github.com/geany/geany-plugins/pull/656.

I can reintroduce the old webkitgtk-1.0 code, but it's going to involve quite a bit of ugly #ifdef-ing because quite a number of things have changed (most of the signals have been completely reorganized to have different meanings and function signatures, so a separate set of callbacks for both the old and new ones would need to be included).

@b4n 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/677

-- Commit Summary --

  * [markdown] Use webkit2gtk3 (webkit2 API)
  * [webhelper] Use webkit2gtk3 (webkit2 API)
  * webhelper: Initial port to webkit2gtk
  * webhelper: Initialize webkit favicon database
  * webhelper: Fix ctrl+scroll zooming in gtk3
  * webhelper: Port context menu to WebKitContextMenu
  * webhelper: Port inspector signal handlers to webkit2gtk
  * webhelper: Port link hovering functionality to webkit2gtk
  * Merge remote-tracking branch 'sergiomb2/master' into webkit2gtk
  * markdown: Use notify::is-loading instead of notify::load-status

-- File Changes --

    M build/markdown.m4 (4)
    M build/webhelper.m4 (4)
    M markdown/src/viewer.c (17)
    M markdown/src/viewer.h (2)
    M webhelper/src/Makefile.am (3)
    M webhelper/src/gwh-browser.c (490)
    M webhelper/src/gwh-browser.h (6)
    M webhelper/src/gwh-plugin.c (50)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/677.patch
https://github.com/geany/geany-plugins/pull/677.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/677
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180117/b12270da/attachment.html>


More information about the Github-comments mailing list