[Github-comments] [geany/geany] Reduce minimum-width of Replace dialog (#1762)

Matthew Brush notifications at xxxxx
Thu Feb 8 01:19:30 UTC 2018


codebrainz commented on this pull request.



>  	GtkSizeGroup *label_size;
 
-	replace_dlg.dialog = gtk_dialog_new_with_buttons(_("Replace"),
-		GTK_WINDOW(main_widgets.window), GTK_DIALOG_DESTROY_WITH_PARENT,
-		GTK_STOCK_CLOSE, GTK_RESPONSE_CANCEL, NULL);
+	replace_dlg.dialog = gtk_dialog_new();

As @elextr mentionedin the PR comments, this doesn't set the transient parent anymore, I believe you can set it with (`gtk_window_set_transient_for()`)[https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-set-transient-for].

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1762#pullrequestreview-94930435
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180208/f417628a/attachment-0001.html>


More information about the Github-comments mailing list