[Github-comments] [geany/geany] WIP: Fix reST and Asciidoc parser scope (#2019)

[elextr]

> I agree with @b4n the current implementation isn't the best

Ok, your example is fairly pathological, its not likely in real documents (not impossible, but not likely), and quite frankly the parser breaks way too often on real documents before something like that needs to be worried about (I can say that since I wrote it)  Examples like mine with repeated headings in different sections are common but work ok.

> but I'd prefer not introducing a diff in Geany now and rather fix it upstream.

Totally agree, the whole point of the exercise is to align with upstream, so lets get to that point (for those parsers where we can eg not c.c) so things get easier.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2019#issuecomment-449187684
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181220/2a8ea8b0/attachment.html>