[Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

[Jiří Techet]

techee commented on this pull request.



> @@ -78,7 +78,7 @@ static void makeAsciidocTag (const vString* const name, const int kind)
 	{
 		tagEntryInfo e;
 
-		initTagEntry (&e, vStringValue (name), &(AsciidocKinds [kind]));
+		initTagEntry (&e, vStringValue (name), kind);
 
 		e.lineNumber--;	/* we want the line before the '---' underline chars */
 

No, this is correct - it's the "Use kindIndex instead of kindDefinition" patch mentioned above. It's now enough to use the index (which is "kind" here) instead of the value from the structure.

But the problem seems to be this patch:

https://github.com/geany/geany/commit/3e8365c7f2285c32ef1372f45afd698449a01ac4#diff-349c047a4c33ab772a7ad84be2c13b4c

Upstream there's some additional comment why using cork isn't good in this case:

https://github.com/universal-ctags/ctags/blob/master/parsers/asciidoc.c

I'll prepare a patch tomorrow to fix that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2018#discussion_r242371090
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181217/c71c1096/attachment.html>