[Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

elextr notifications at xxxxx
Tue Dec 18 00:30:12 UTC 2018


elextr commented on this pull request.



> @@ -78,7 +78,7 @@ static void makeAsciidocTag (const vString* const name, const int kind)
 	{
 		tagEntryInfo e;
 
-		initTagEntry (&e, vStringValue (name), &(AsciidocKinds [kind]));
+		initTagEntry (&e, vStringValue (name), kind);
 
 		e.lineNumber--;	/* we want the line before the '---' underline chars */
 

I suspect the scope information that used to be stored in extensions about here is the cause of the breakage of asciidoc structuring and similar change for rest.  Needs to be fixed, note that if upstream won't accept it then these two parsers will have to remain Geany specific.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2018#pullrequestreview-185859507
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181217/2d2e7945/attachment.html>


More information about the Github-comments mailing list