[Github-comments] [geany/geany] Sync ctags main part (#1263)

[Colomban Wendling]

b4n commented on this pull request.



>  
 	if (vStringLength (name) > 0)
 	{
+		tagEntryInfo *parent = getEntryOfNestingLevel (nl);

It's incorrect, because I stated in my commend above, we still have to call `getNestingLevel()` because it's that function that calls `nestingLevelsPop()` when appropriate.  Just removing the call removes this side effect, resulting in never removing nest levels.

This is pretty much exactly what I tried to warn about in the comment above when sating that *"have a tendency to remove [unused variables]"*, suggesting it's not so simple here.  What we can do is call the function without storing its value, and possible rename it to be clearer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1263#discussion_r242294608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181217/9fa82e2a/attachment-0001.html>