[Github-comments] [geany/geany] Fix 'changed' flag being altered when all documents are closing. (#1857)

[Colomban Wendling]

@elextr well, I rather see that as a plain bug, and I'm not sure we really want bug-for-bug compatibility… and here all that I can see as incompatible behavior is that now plugins would know that a file is *not* saved when quitting, which is basically giving it more, or at least correct, information.  I fail to see any case that was correct but would be compromised because of getting correct information on this; if anything it would introduce different behavior because the code *explicitly wanted to perform different actions depending on the saved state* but was lied to, and thus only likely to perform incorrectly in the first place.

And in any case, we broke ABI in this release (3fa7576e13e129900a6e0acbd5460237f9a1b614), would that be enough for you?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1857#issuecomment-443617229
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181202/e8e2674d/attachment.html>