[Github-comments] [geany/geany-plugins] Issue737 treebrowser follow doc fix (#796)

Enrico Tröger notifications at xxxxx
Sun Dec 2 17:25:44 UTC 2018


This fixes following the current document path.
As mentioned in #737 this was broken on Windows but actually it was broken on non-Windows as well if the start directory (Geany's default open directory or the project base directory) has no common parts with the current document's file path.

For Windows, there was an additional hack necessary: ignoring the drive letter completely in all checks.
This made it working for the moment but obviously breaks a lot of the plugin's functionality if files on another drive than the current are handled.
This should be fixed properly but since the fact that I don't use the plugin and my available time is limited, I won't do myself.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/796

-- Commit Summary --

  * TreeBrowser: Fix wording
  * TreeBrowser: Fix memory leaks
  * TreeBrowser: Always search the whole path when trying to find current file in tree
  * TreeBrowser: Unify plugin signal connect methods
  * TreeBrowser: Strip drive letter on Windows

-- File Changes --

    M treebrowser/src/treebrowser.c (98)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/796.patch
https://github.com/geany/geany-plugins/pull/796.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/796
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181202/86bb1893/attachment.html>


More information about the Github-comments mailing list