[Github-comments] [geany/geany] #1907 Add preferences flag to skip the project_ask_close dialog (#1908)

[elextr]

The reason you are getting all the updates and all other changes you make is that you have made the pull request from master not from a branch.  If you make a branch there is not need to touch it once you have made the pull request, (except if changes are needed :) and so the PR doesn't see all the noise or accidently get other changes you make (especially as you will make those in other branches now you know about them :) and your master will be clean and able to pull upstream changes without problems.  It also makes it easier for testers to not pollute their master with your changes.

Sorry should have pinged you on that first but I didn't notice it wasn't a branch.

On the PR itself.

We don't really want to add more trash to the various prefs, but on the other hand adding it to the proper prefs UI needs Glade 3.8.5 (@kugel does 3.8.6 work?) and on any reasonably recent distro that version is not in the package repository so you have to build it yourself from source.

Otherwise it looks ok by quick inspection, not tested.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1908#issuecomment-416872261
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180829/3b76b047/attachment.html>