[Github-comments] [geany/geany] Correction and enhancements for context action (#1841)

[Alex Plotnikov]

To be consistent with Compile/ Run/ Build the following modification should be done:

    gchar *command_orig = g_strdup(command);
    gchar *command_line = build_replace_placeholder(doc, command_orig);
    gint isfilecontext = strcmp(command_orig, command_line) != 0;
    g_free(command_orig);
    if (isfilecontext && doc && doc->changed) //save file if it's in context
    {
            if (!document_save_file(doc, FALSE))
                return;
    }

This provides 'save before run' feature for the edited file if the context string contains %f, %d etc. placeholders.
I don't know how to explain this more clearly. Perhaps I'm a bad explainer and a bad boy at that. You folks are much more clear about a separate PR from context action etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1841#issuecomment-384507413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180425/ce800547/attachment-0001.html>