[Github-comments] [geany/geany] Correction and enhancements for context action (#1841)

elextr notifications at xxxxx
Tue Apr 24 23:04:44 UTC 2018


> The context doesn't work at that, of course. It should not be enabled: 1) when no text is selected

IIUC its a deliberate feature to select the word under the cursor if no selection exists, so this will need an option defaulting to off so it won't affect the current behaviour unless the user wants it to.

> 2) even more important: when there is no context action set.

Making the menu item insensitive in this case makes sense.

> This commit introduces %f, %d, %e, %p, %l placeholders into the context string, i.e. the same ones as in Compile/ Build/ Run.

Seems a worthwhile improvement.

>  the set context action is active when there is no selected text or a word under caret. 

Erm, didn't your item 1. just propose disabling it in this case?

Finally, this will __NOT__ be accepted without the manual being modified to reflect the changes.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1841#issuecomment-384107256
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180424/81ff6ccc/attachment.html>


More information about the Github-comments mailing list