[Github-comments] [geany/geany] keybindings: Added missing "Strip Trailing Spaces" (#1806)

[elextr]

elextr commented on this pull request.



> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
 	GEANY_KEYS_FORMAT_SENDTOCMD8,				/**< Keybinding. */
 	GEANY_KEYS_FORMAT_SENDTOCMD9,				/**< Keybinding. */
 	GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,	/**< Keybinding. */
+	GEANY_KEYS_DOCUMENT_STRIPTRAILINGSPACES,	/**< Keybinding. 
+												 * @since 1.34   */

Well, now @b4n has brought it up, yes this should increment the API, but probably not the ABI since although GEANY_KEYS_COUNT will change it says "must not be used in plugins".  And IMO the `@since` should be the API, thats what plugin writers care about and need to specify to ensure a compatible Geany version.  Theoretically the API could change several times in a release cycle, though that was more of a problem back when it was years (literally) between releases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#discussion_r179616956
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180405/62df5303/attachment.html>