[Github-comments] [geany/geany] Add support for platform-specific keybindings (#1395)

[Colomban Wendling]

b4n commented on this pull request.



> @@ -782,6 +768,36 @@ static void load_kb(GeanyKeyGroup *group, GeanyKeyBinding *kb, gpointer user_dat
 }
 
 
+static void init_platform_kb(void)
+{
+#ifdef __APPLE__
+	gchar *configfile = g_build_filename(app->datadir, "keybindings_osx.conf", NULL);

@techee hum, we don't have a system-wide keybindings file yet, so I don't really see the difference between what I did and what you suggest?  OK, if we wanted to have default keybindings in a system config file instead of hard-coded it would make sense (and it might be a good thing for the future), but unless I miss something we currently don't.

> Also I think it would be best to keep the platform-specific keybinding files inside the data dir in sources and not to move it under osx as they will usually have to be updated together.

Yeah… well the problem is that Autotools don't make it easy to rename a file when installing it, hence the reason why I put it in a sub-directory so it can have the same name for each platform.  But it's possible to do a rename, just not very nice.  (yes, it's a sometimes annoying limitation of Autotools -- although generally renaming files means you could not use a non-installed version of your software, but well)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1395#discussion_r141976349
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170929/034d0d17/attachment.html>