[Github-comments] [geany/geany] Fix the symbols tree hierarchy when several tags have the same name (#1598)

[Jiří Techet]

techee commented on this pull request.



>  	GTree *tree;
-	if (g_hash_table_lookup_extended(table, tag->name, NULL, (gpointer *) &tree) &&
-		! utils_str_equal(parent_name, tag->name) /* prevent Foo::Foo from making parent = child */)
+
+	if (EMPTY(tag->scope))
+	{
+		/* simple case, just use the tag name */
+		name = tag->name;

What about doing g_strdup(tag->name) here and once more below and completely eliminating the name_free variable?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1598#pullrequestreview-64739676
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170923/8e08844b/attachment.html>