[Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

Colomban Wendling notifications at xxxxx
Mon Sep 18 18:03:21 UTC 2017


b4n commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are unicode */

I guess yeah ideally the placeholder wouldn't be any actual character but simply a display thing, but I'm not sure Scintilla allows for this, does it?  It would need be able to have an indicator that takes more room than the range it's on, which doesn't sounds likely, but I might miss an existing feature.

Otherwise for what the placeholder is I don't care that much; I just didn't feel like `_` looked straightforward to me when using the thing, but I don't have a string opinion either.  I still feel like https://github.com/geany/geany/commit/957b49b868214a4aea81641dedeabb98a497e4c1#commitcomment-23346900, but if the consensus is to keep `_` I won't argue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139496331
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170918/13247139/attachment.html>


More information about the Github-comments mailing list