[Github-comments] [geany/geany-plugins] Connect button-press signal handlers on plugin activation (#639)

[Colomban Wendling]

b4n commented on this pull request.



> @@ -78,6 +79,13 @@ static void ao_mark_word_set_property(GObject *object, guint prop_id,
 	{
 		case PROP_ENABLE_MARKWORD:
 			priv->enable_markword = g_value_get_boolean(value);
+			/* if the plugin is loaded while Geany is already running, we need to connect the
+			 * button press signal for open documents, if Geany is just booting,
+			 * it happens automatically */
+			if (main_is_realized())

shouldn't this check for `priv->enable_markword` too, not to do that on deactivation as well?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/639#pullrequestreview-72703214
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171029/f6d4917d/attachment-0001.html>