[Github-comments] [geany/geany] Make sure GDK_MOD2_MASK is cleared when getting modifiers (#1636)

Colomban Wendling notifications at xxxxx
Thu Oct 12 22:11:58 UTC 2017


b4n commented on this pull request.



>  		mods |= GEANY_PRIMARY_MOD_MASK;
+		mods &= ~GDK_MOD2_MASK;

Unless I'm mistaken, in the expression above `^` has priority over `|` so it's the same as `(mods ^ GDK_MOD2_MASK) | GEANY_PRIMARY_MOD_MASK`.
But the simple fact you said what you did makes your version better, as it's then less confusing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1636#discussion_r144423385
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171012/115a232d/attachment-0001.html>


More information about the Github-comments mailing list