[Github-comments] [geany/geany] Use non-symlinked VTE libraries on macOS (#1625)

[Colomban Wendling]

b4n commented on this pull request.



>  #else
-			"libvte.so", "libvte.so.4", "libvte.so.8", "libvte.so.9", "libvte.dylib",
+			"libvte.so", "libvte.so.4", "libvte.so.8", "libvte.so.9", "libvte.9.dylib",

I don't really know, but e.g. the `libvte.so` symlink is installed by the `libvte-dev` package on Debian; a user with only the `libvte9` package will use the `libvte.so.9` name.
BTW, we might like inverting the order of the versioned names so the newest is taken first?

Anyway, I don't know OSX, but if the VTE library sticks to the *NIX kind of rules it'll install a versioned version anyway, so I'd say it's unlikely to have the versioned version missing.  But OTOH, if the versioned version is missing and the unversioned one is present it'd be a little silly not to use it.

All this said, the underlying problem is more subtle, and I guess would happen with any 2 libraries we load that share used symbols -- e.g. if in the future there was a newer version of the VTE library and the plugins got linked to this, the same problem would happen until we list the new SONAME here… leading to the conclusion that the best thing would be to keep the symlink instead of copying the file :)  But well.  I don't have a strong option/solution here, but would naively think listing the unversioned name as a fallback would make sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1625#discussion_r142818578
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171004/7a48b2c1/attachment.html>