[Github-comments] [geany/geany-plugins] Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. (#608)

[Colomban Wendling]

b4n commented on this pull request.



> @@ -245,14 +248,17 @@ static GSList *wb_project_dir_get_file_list(WB_PROJECT_DIR *root, const gchar *u
 
 	g_hash_table_insert(visited_paths, real_path, GINT_TO_POINTER(1));
 
-	while (TRUE)
+	while ((child_name = g_dir_read_name(dir)))

I don't think repeating the call is a good idea.  I don't mind the original code myself, but some people prefer things like this: `while ((child_name = g_dir_read_name(dir)) != NULL)` so it's more obvious the assignation is not a typo.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/608#discussion_r142766122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171004/ae137552/attachment.html>