[Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)
Thomas Martitz
notifications at xxxxx
Wed Nov 15 15:44:59 UTC 2017
Am 15.11.2017 um 15:40 schrieb elextr:
> @kugel- <https://github.com/kugel-> sadly I think we have to have a work
> around in Geany, even if there is a fix in Glib, there are at least 10
> versions in the wild with the problem by @b4n <https://github.com/b4n>'s
> post above, so either Geany becomes tolerant of those versions, or
> (IIUC) scope is unusable on systems with those versions (and more
> versions until its fixed).
>
> So long as polling does not kick in on anything other than things
> associated with scope plugin I guess its an ok fix, even if it does not
> return to non-polling. As for adding to this release, unless @b4n
> <https://github.com/b4n> is happy he has tested it enough I would wait,
> lets not have to have a 1.32.1 to fix the fix :)
>
The other side of the medal is that Geany itself is not affected, just a
plugin that the author itself considers orphaned/unmaintaned, so I'm not
sure a non-trivial change inside Geany is justified.
FWIW, I'm not against merging the change, I don't feel very strong. I'm
rather indifferent since I don't use scope (doesn't support gtk3).
But if we accept it, then better for 1.32. This is sitting for a long
time already and has been tested by at least two individuals already.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1461#issuecomment-344633224
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171115/20f0c558/attachment-0001.html>
More information about the Github-comments
mailing list