[Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)
Thomas Martitz
notifications at xxxxx
Fri Nov 10 15:24:02 UTC 2017
kugel- requested changes on this pull request.
Let's back out b9982368889354cfa010e5906cd5f477f7b90f35 and merge the rest, until we agree on a placeholder.
> @@ -2394,7 +2394,7 @@ typedef struct
} SelectionRange;
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are unicode */
Since we don't agree let's post-pone this very change. The rest of the PR is good and should be merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#pullrequestreview-75788638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171110/a40e03f0/attachment.html>
More information about the Github-comments
mailing list