[Github-comments] [geany/geany] Add missing string and comment styles for various lexers (#1502)

[elextr]

Irrespective of the uses in plugins, Geany core uses `highlighting_is_code_style()` for:

* matching parentheses, definitely don't want to do that in regexes
* brace indenting, don't want to see braces in regexes
* get line end position, hmm this might want to see regexes as code, not sure
* parens in calltip handling, don't want to match in regexes
* enabling autocomplete (so it doesn't happen in strings and comments) and that should exclude regexes as well

That seems to suggest that in core most places regexes should not be counted as code.  My simple solution was to put them in `highlighting_is_string_style()` since it already has the basic infrastructure, but I understand that upsets spell checking and maybe other uses of `highlighting_is_string_style()` so I guess that says we need to add them to `highlighting_is_code_style()` or have a `highlighting_is_regex_style()` that it can use.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1502#issuecomment-304508272
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170528/b3cbb852/attachment.html>