[Github-comments] [geany/geany] Fix search marker translucency (currently ignoring scheme) (#1490)

Galland notifications at xxxxx
Wed May 3 16:43:44 UTC 2017


On filetypes common it says: "# translucency for the line marker(first argument) and the search marker (second argument)
marker_translucency=255;255"
However changing the 2nd argument does NOT affect search marker translucency.
The proposed change addresses this.

On the downside: current hard-coded value of 60 (very transparent) would become filetypes.common's default of 255 (no transparency).

On the upside:
1) we would be consistent with what is indicated in filetypes.common about translucency for the search marker
2) this change may help all DARK themes, since marked words are barely visible no matter the GCS_MARKER_SEARCH background color used. By changing the translucency we can make them standout, just like in white themes.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1490

-- Commit Summary --

  * Fix search marker translucency (currently ignoring scheme)

-- File Changes --

    M src/highlighting.c (2)

-- Patch Links --

https://github.com/geany/geany/pull/1490.patch
https://github.com/geany/geany/pull/1490.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1490
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170503/615c05c9/attachment.html>


More information about the Github-comments mailing list