[Github-comments] [geany/geany] Export keybindings_load_keyfile() for plugins (#1430)

[Thomas Martitz]

kugel- requested changes on this pull request.



> @@ -824,6 +824,15 @@ static void apply_kb_accel(GeanyKeyGroup *group, GeanyKeyBinding *kb, gpointer u
 }
 
 
+/** Reloads keybinding settings from configuration file. Normally plugins do
+ * not need to call this function as it is called automatically when a the
+ * plugin is activated. However, plugins which need to create keybindings
+ * dynamically and reload them when needed should call this function after
+ * all keybindings have been updated with plugin_set_key_group() and
+ * keybindings_set_item() calls - this makes sure that the corresponding user
+ * keybinding shortcuts are applied.
+ * @since 1.31. */

Recently we used "@since X.YY (API ZZZ)" (with api version, without trailing dot). The API version tends to be more interesting for plugin developers. Please change this accordingly.

> @@ -824,6 +824,15 @@ static void apply_kb_accel(GeanyKeyGroup *group, GeanyKeyBinding *kb, gpointer u
 }
 
 
+/** Reloads keybinding settings from configuration file. Normally plugins do

The first sentence should be separate, doxygen generates a brief one-liner for this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1430#pullrequestreview-29481575
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170328/2a0ba4d4/attachment.html>