[Github-comments] [geany/geany] Clicking Help in Preferences results in URI Not Found on Win7 (#1522)

[Matthew Brush]

> The reason we use ShellExecute("open", uri, ...) on Windows is that it's the easiest way to open the system's default browser without any hassle.

Probably before, but since GTK+ 2.14 I think the simplest and most robust way should be [`gtk_show_uri()`](https://developer.gnome.org/gtk3/stable/gtk3-Filesystem-utilities.html#gtk-show-uri) (or the misdocumented `_on_window()` variant for newer GTK+).

> instead of unconditionally use ShellExecute on Windows, use the browser command configured in the preferences and maybe fallback to ShellExecute in case no browser is configured

+1, though I'd fallback on `gtk_show_uri()` if it works OK on Windows (and _then_ maybe fall back to `ShellExecute()` or even `iexplore` or whatever). Also, it should fallback if either the browser isn't configured or if the configured application fails to launch, for example if Firefox isn't installed, as @elextr mentioned.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1522#issuecomment-310924633
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170625/ac9fe470/attachment.html>