[Github-comments] [geany/geany-plugins] geanyprj/workingdir (#486)

Anthony Loiseau notifications at xxxxx
Sat Jun 17 16:50:05 UTC 2017


Thannoy commented on this pull request.



> @@ -311,6 +315,14 @@ void geany_project_set_run_cmd(struct GeanyPrj *prj, const gchar *run_cmd)
 }
 
 
+void geany_project_set_working_dir(struct GeanyPrj *prj, const gchar *working_dir)
+{
+	if (prj->working_dir)
+		g_free(prj->working_dir);

(minor) You can `g_free` unconditionally since freeing NULL is a valid no-op (cd manual [here](https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free)).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/486#pullrequestreview-44703891
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170617/11899606/attachment.html>


More information about the Github-comments mailing list